Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find extrema when creating an AstroImage #13

Merged
merged 4 commits into from Aug 26, 2019

Conversation

giordano
Copy link
Member

@giordano giordano commented Apr 6, 2019

This would make render much faster.

My only concern is that I'm not yet sure render would be used very often

This would make `render` much faster.
@codecov-io
Copy link

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #13   +/-   ##
====================================
  Coverage      95%   95%           
====================================
  Files           3     3           
  Lines          20    20           
====================================
  Hits           19    19           
  Misses          1     1
Impacted Files Coverage Δ
src/AstroImages.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e921f...0388448. Read the comment docs.

@aquatiko
Copy link
Member

@giordano render is used very often to render the canvas in AstroImageView.jl. I think it will be good to include this now.

@giordano
Copy link
Member Author

Would you be able to merge master on that branch and fix conflicting changes? You can open a PR on https://github.com/giordano/AstroImages.jl against branch minmax

@giordano giordano merged commit e8dd2d5 into JuliaAstro:master Aug 26, 2019
@giordano giordano deleted the minmax branch August 26, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants