Muti File support #21
Conversation
|
Also, here I am adding things in an empty array and then converting to a tuple. Is there a way to push these directly to a tuple? |
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 94.91% 98.66% +3.75%
==========================================
Files 3 3
Lines 59 75 +16
==========================================
+ Hits 56 74 +18
+ Misses 3 1 -2
Continue to review full report at Codecov.
|
|
Tests are not passing on Windows, with any Julia version. WebIO cannot be built, but this looks unrelated to the actual errors reported down in the log. |
src/AstroImages.jl
Outdated
| @@ -8,7 +8,11 @@ export load, AstroImage | |||
|
|
|||
| _load(fits::FITS, ext::Int) = read(fits[ext]) | |||
| _load(fits::FITS, ext::NTuple{N, Int}) where {N} = ntuple(i-> read(fits[ext[i]]), N) | |||
| _load(fits::NTuple{N, String}) where {N} = ntuple(i-> FITS(fits[i]), N) | |||
There was a problem hiding this comment.
This method has a different semantic compared to the other _load methods: it returns a bunch of FITSes, instead of reading a FITS passed as input. This makes the code harder to follow, and perhaps more error-prone
| error("There are no ImageHDU extensions in \"$file\"") | ||
| end | ||
| out = AstroImage(Gray, fits, ext) | ||
| close(fits) |
There was a problem hiding this comment.
I think that by removing this method you're not closing the FITS file any more, are you?
There was a problem hiding this comment.
You were right, this along with a couple more things were causing appvyeor to fail.
|
@giordano can this be merged now? |
No description provided.