Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adstring method #74

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Conversation

Aman-Pandey-afk
Copy link
Contributor

@Aman-Pandey-afk Aman-Pandey-afk commented Mar 30, 2022

Fixing the issue #57

@Aman-Pandey-afk
Copy link
Contributor Author

@giordano Should I use two lines to implement the change and make a new commit or anything else to overcome this failed codecov check or can this be ignored. Also, feedback on the implementation will be great. (Used absolute function + int cast and sign of dec to correctly mention the signs of string for dec between 0 and -1)

@giordano
Copy link
Member

giordano commented Mar 31, 2022

The codecov failure isn't fatal (I believe it detects a fractional decrease of covered lines because there are fewer lines with your change). However you still haven't added a test for the issue this PR is supposed to fix 🙂

@Aman-Pandey-afk
Copy link
Contributor Author

I added the test mentioned in the issue ( adstring(15, -0.5) ) in the utils-tests.jl and tested it to be passed. I have made it a separate commit as it is for testing purpose (can be merged if needed). Do I need to do anything else (is the codecov skippable or any other advice)? @giordano

@giordano giordano linked an issue Apr 4, 2022 that may be closed by this pull request
@giordano
Copy link
Member

giordano commented Apr 4, 2022

Thank you!

@giordano giordano merged commit f745f52 into JuliaAstro:master Apr 4, 2022
@Aman-Pandey-afk Aman-Pandey-afk deleted the stringfix branch April 5, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adstring outputs wrong string with negative zero
2 participants