Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported Tttdb #20

Merged
merged 4 commits into from
May 13, 2018
Merged

Ported Tttdb #20

merged 4 commits into from
May 13, 2018

Conversation

prakharcode
Copy link
Contributor

@prakharcode prakharcode commented May 12, 2018 •
edited

#1

@coveralls
Copy link

coveralls commented May 12, 2018 •
edited

Pull Request Test Coverage Report for Build 151

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 97.482%
Totals Coverage Status
Change from base Build 149: 0.07%
Covered Lines: 271
Relevant Lines: 278
💛 - Coveralls

@codecov-io
Copy link

codecov-io commented May 12, 2018 •
edited

Codecov Report

Merging #20 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   97.41%   97.48%   +0.06%     
==========================================
  Files           6        6              
  Lines         271      278       +7     
==========================================
+ Hits          264      271       +7     
  Misses          7        7
Impacted Files Coverage Δ
src/conversions.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1894edf...b54d0ce. Read the comment docs.

helgee
helgee reviewed May 12, 2018
View reviewed changes
src/conversions.jl Outdated
"""
@inline function tttdb(jd1, jd2, dtr)
dtrd = dtr / SECONDS_PER_DAY
if jd1 > jd2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off

@helgee
Copy link
Member

helgee commented May 12, 2018

LGTM modulo comments

@helgee helgee mentioned this pull request May 12, 2018
Closed
20 tasks
@helgee helgee merged commit c2aaac3 into JuliaAstro:master May 13, 2018
@prakharcode prakharcode deleted the tttdb branch July 1, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helgee helgee helgee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prakharcode @coveralls @codecov-io @helgee