Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Cal2jd #29

Merged
merged 4 commits into from
Jun 6, 2018
Merged

Ported Cal2jd #29

merged 4 commits into from
Jun 6, 2018

Conversation

prakharcode
Copy link
Contributor

Test added for leap year and non-leap year.

@coveralls
Copy link

coveralls commented Jun 6, 2018

Pull Request Test Coverage Report for Build 180

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 87.404%

Totals Coverage Status
Change from base Build 179: 0.5%
Covered Lines: 340
Relevant Lines: 389

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Jun 6, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@3712df7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   86.49%           
=========================================
  Files             ?        7           
  Lines             ?      348           
  Branches          ?        0           
=========================================
  Hits              ?      301           
  Misses            ?       47           
  Partials          ?        0
Impacted Files Coverage Δ
src/conversions.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3712df7...aecafcf. Read the comment docs.

@helgee helgee merged commit 3799fae into JuliaAstro:master Jun 6, 2018
@prakharcode prakharcode deleted the cal2jd branch July 1, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants