[WIP] Rewrite the whole thing based on a high-accuracy epoch type #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=========================================
+ Coverage 87.38% 92.3% +4.92%
=========================================
Files 7 7
Lines 539 169 -370
=========================================
- Hits 471 156 -315
+ Misses 68 13 -55
Continue to review full report at Codecov.
|
giordano
reviewed
Jul 1, 2018
test/epochs.jl
Outdated
| ep1 = Epoch2{TDB}(ep, -Inf) | ||
| @test ep1.epoch == typemin(Int64) | ||
| @test ep1.offset == -Inf | ||
| end |
There was a problem hiding this comment.
New line at the end of the file 🙂
src/Epochs2.jl
Outdated
|
|
||
| Epoch2{S}(ep::Epoch2{S}, Δt) where {S} = Epoch2{S}(ep.epoch, ep.offset, Δt) | ||
|
|
||
| end |
There was a problem hiding this comment.
Missing newline at the end of the file (or extra empty incomplete line) 🙂
helgee
changed the title
|
@giordano Do you happen to know how one overloads the colon operator? |
|
It used to be lowered to the |
If timestamps are time-scale-agnostic than a conversion is just a relabeling, duh!
|
...and we have ranges 🎉 |
This was referenced Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got started with a new accuracy-preserving type. The design is based on the
AbsoluteDateclass from Orekit: https://github.com/CS-SI/Orekit/blob/develop/src/main/java/org/orekit/time/AbsoluteDate.javaEDIT: This is basically a straight port of Orekit's time package. Imitation is the sincerest form of flattery 😉
CC: @bgodard, @giordano, @prakharcode
ToDo