Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.7 Compatibility - Fix out-of-sync tests and deprecations #39

Merged
merged 2 commits into from Jun 18, 2018
Merged

Conversation

helgee
Copy link
Member

@helgee helgee commented Jun 17, 2018

Some tests were failing because the reference values were out of sync with the original ERFA source. No idea why they did not throw on 0.6 🤷‍♂️

@helgee helgee changed the title 0.7 comaptibility - Fix out-of-sync tests and deprecations 0.7 Compatibility - Fix out-of-sync tests and deprecations Jun 17, 2018
@coveralls
Copy link

coveralls commented Jun 17, 2018

Pull Request Test Coverage Report for Build 125

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.6%) to 91.63%

Totals Coverage Status
Change from base Build 121: 2.6%
Covered Lines: 624
Relevant Lines: 681

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Jun 17, 2018

Codecov Report

Merging #39 into master will increase coverage by 2.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   88.98%   91.62%   +2.64%     
==========================================
  Files          21       21              
  Lines         681      681              
==========================================
+ Hits          606      624      +18     
+ Misses         75       57      -18
Impacted Files Coverage Δ
src/n.jl 100% <ø> (ø) ⬆️
src/x.jl 100% <ø> (ø) ⬆️
src/o.jl 100% <ø> (ø) ⬆️
src/b.jl 100% <ø> (ø) ⬆️
src/a.jl 88.96% <ø> (ø) ⬆️
src/l.jl 100% <ø> (ø) ⬆️
src/s.jl 82.35% <ø> (+3.92%) ⬆️
src/e.jl 92.3% <ø> (ø) ⬆️
src/ERFA.jl 100% <ø> (ø) ⬆️
src/t.jl 89.28% <ø> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b0b42...226b3e9. Read the comment docs.

@helgee helgee merged commit 4aefd1c into master Jun 18, 2018
@helgee helgee deleted the 0.7 branch June 18, 2018 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants