Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Estimation Framework #11

Merged
merged 7 commits into from
Feb 27, 2020
Merged

Background Estimation Framework #11

merged 7 commits into from
Feb 27, 2020

Conversation

mileslucas
Copy link
Member

This PR will work on background estimation, trying to implement as many algorithms as possible.

I will begin by setting up the generic framework for background estimation, allowing the introduction and implementation of many different algorithms under a common API (similar to photutils).

@giordano
Copy link
Member

Codecov Report

Merging #11 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files           6        6           
  Lines         419      419           
=======================================
  Hits          407      407           
  Misses         12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99f5ec...4ba9972. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #11 into master will decrease coverage by 0.41%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   97.13%   96.72%   -0.42%     
==========================================
  Files           6        8       +2     
  Lines         419      427       +8     
==========================================
+ Hits          407      413       +6     
- Misses         12       14       +2
Impacted Files Coverage Δ
src/Photometry.jl 100% <ø> (ø) ⬆️
src/Aperture/Aperture.jl 100% <ø> (ø) ⬆️
src/Aperture/elliptical.jl 98.73% <ø> (ø) ⬆️
src/Aperture/circular.jl 96.29% <ø> (ø) ⬆️
src/Background/stat_estimators.jl 100% <100%> (ø)
src/Background/Background.jl 66.66% <66.66%> (ø)
src/Aperture/overlap.jl 95.72% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99f5ec...fa5e2d6. Read the comment docs.

@mileslucas mileslucas marked this pull request as ready for review February 27, 2020 01:50
@mileslucas mileslucas merged commit 7c7797a into master Feb 27, 2020
@mileslucas mileslucas deleted the background branch February 27, 2020 01:53
@mileslucas mileslucas mentioned this pull request Feb 27, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants