Added Median for background estimation #15
Conversation
|
This PR seems to be based on #14? Could you please start a branch out of |
|
This PR uses the function |
|
Right. This makes managing PRs much harder for us. Now we have to keep in mind that we can't merge this without merging the sigma-clip method. PRs should usually be based on the current upstream master. |
There was a problem hiding this comment.
Please don't use the sigma clipping inside these methods. I explicitly didn't put it into the Mean estimator for a reason.
Even though astropy does this, it seems counter-intuitive to me.
If I want to sigma clip my data before processing it, I should just sigma clip my data before processing it ie
bkg = estimate_background(Mean, sigma_clip(data))Does this make sense?
When you remove all the sigma clipping you should also be able to work on this independent of #14
|
Understood, I will remove the instances of sigma clipping from the median part and rebase it on the current master branch. 🙂 |
siddharthlal25
force-pushed
the
median
branch
from
54c63ff
to
c06d73b
Compare
Added median statistic for background estimation as mentioned in issue #12