Added MMMBackground to estimate background #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mileslucas
requested changes
Mar 4, 2020
There was a problem hiding this comment.
See updates about structure usage.
If we only use the structs for dispatching, we'd be better off writing a separate function for each of them! Any attributes particular to a background estimator should be part of the background estimator's struct. I hope that makes sense!
Also, I'm missing a documentation entry in docs/src/background/estimators.md.
mileslucas
requested changes
Mar 7, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MMMBackground estimator as mentioned in #12