Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Background Estimation #23

Merged
merged 26 commits into from
Mar 15, 2020
Merged

2D Background Estimation #23

merged 26 commits into from
Mar 15, 2020

Conversation

mileslucas
Copy link
Member

This PR is working on adding the 2D meshing for the background and a zoom interpolater.

This has changed some of the interface for the BackgroundEstimators and has added BackgroundRMSEstimator with implementations for Std MadStd and BiweightScale.

@mileslucas mileslucas self-assigned this Mar 12, 2020
@mileslucas
Copy link
Member Author

mileslucas commented Mar 13, 2020

Todo:

  • mesh creation
  • crop mode
  • pad mode (array creation is fine, but NaN math breaks it)
  • zoom interpolator
  • tests for the above
  • docs for the above
  • figure out a way to do iterative sigma-clipping within estimate_background call.

@codecov-io
Copy link

codecov-io commented Mar 13, 2020

Codecov Report

Merging #23 into master will increase coverage by 2.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   95.17%   97.62%   +2.45%     
==========================================
  Files           9       10       +1     
  Lines         580      631      +51     
==========================================
+ Hits          552      616      +64     
+ Misses         28       15      -13     
Impacted Files Coverage Δ
src/Aperture/Aperture.jl 100.00% <ø> (ø)
src/Aperture/circular.jl 96.29% <ø> (ø)
src/Aperture/elliptical.jl 98.73% <ø> (ø)
src/Aperture/overlap.jl 95.92% <ø> (ø)
src/Aperture/plotting.jl 100.00% <ø> (ø)
src/Aperture/rectangle.jl 95.74% <ø> (ø)
src/Background/Background.jl 100.00% <100.00%> (+25.00%) ⬆️
src/Background/estimators.jl 100.00% <100.00%> (+32.35%) ⬆️
src/Background/interpolators.jl 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8bfff...5f4b241. Read the comment docs.

@mileslucas mileslucas mentioned this pull request Mar 13, 2020
6 tasks
@mileslucas mileslucas changed the title [WIP] 2D Background Estimation 2D Background Estimation Mar 14, 2020
@mileslucas mileslucas merged commit 47df826 into master Mar 15, 2020
@mileslucas mileslucas deleted the background branch March 15, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants