Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to CI #1

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Some improvements to CI #1

merged 1 commit into from
Feb 20, 2021

Conversation

giordano
Copy link
Member

  • Documentation: build with latest version of Julia 1.x
  • TagBot: use newer setup, see documentation
  • CI: remove duplicate documentation job

Usually I run CI on 3 versions of Julia:

  • the oldest one I claim support for (in your case it would be "1.0")
  • the latest stable version (can be indicated with "1")
  • "nightly"

I didn't change this, leaving the decision up to you.

Also, for most of my packages I don't fiddle too much with internals, where 32-
vs 64-bit would matter, so I usually don't run CI on 32-bit systems at all, to
save some resources. I'm leaving also this up to you 😉

* Documentation: build with latest version of Julia 1.x
* TagBot: use newer setup, see [documentation](https://github.com/JuliaRegistries/TagBot/blob/afea108e2cd6116e3cf366b55f116b8c257ae0f2/README.md#setup)
* CI: remove duplicate documentation job
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1 (f4b68ce) into main (5920574) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files           2        2           
  Lines         112      112           
=======================================
  Hits          111      111           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5920574...799c8b3. Read the comment docs.

@giordano
Copy link
Member Author

giordano commented Feb 19, 2021

I didn't touch the Manifest.toml files, but personally I don't find them very useful for packages: they're picked up by CI jobs, which effectively prevents you from testing the package with different versions of the dependencies, as they come out.

On the contrary, manifest files are absolutely important in "applications" (which can be the script you actually use to run an analysis pipeline): with the manifest you record the status of all dependencies, so that you can reproduce exactly the same analysis later or on a different system.

@matteobachetti
Copy link
Collaborator

@giordano thanks a lot for this PR! One of the reasons why I had Julia 1.0 out was that some dependencies were broken. I figured that this package will run on Julia 1.5+ anyway, given that it is so new and in such an early state.
About dependencies: it wasn't clear to me how to specify dependencies without the Manifest file actually, as my first experiments failed due to that. Could you give me an example? Thanks!

@matteobachetti matteobachetti merged commit 4e80dc0 into JuliaAstro:main Feb 20, 2021
@matteobachetti matteobachetti mentioned this pull request Feb 20, 2021
@giordano giordano deleted the mg/ci branch February 20, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants