New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JLL package #14
Use JLL package #14
Conversation
Pull Request Test Coverage Report for Build 248
💛 - Coveralls |
Yes, I'm not afraid of removing support for old versions of Julia: they won't enjoy new releases of the package, but the old ones will of course work. I believe the much easier installation and lower maintenance are worth the breakage. Note that cirrus CI is probably kind of broken. You can just drop it and add |
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
- Coverage 99.22% 98.91% -0.31%
==========================================
Files 27 27
Lines 2568 2573 +5
==========================================
- Hits 2548 2545 -3
- Misses 20 28 +8
Continue to review full report at Codecov.
|
In principle it would suffice to test on 1.5 and nightly, right? |
I usually test packages with the oldest supported version of Julia ( |
...in addition to nightly |
@giordano Do you think it's fine to just drop pre-1.3 Julia versions here? There are no new features or bug fixes and the old versions will remain functional.