Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JLL package #14

Merged
merged 7 commits into from Aug 3, 2020
Merged

Use JLL package #14

merged 7 commits into from Aug 3, 2020

Conversation

helgee
Copy link
Member

@helgee helgee commented Aug 2, 2020

@giordano Do you think it's fine to just drop pre-1.3 Julia versions here? There are no new features or bug fixes and the old versions will remain functional.

@coveralls
Copy link

coveralls commented Aug 2, 2020

Pull Request Test Coverage Report for Build 248

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 98.912%

Files with Coverage Reduction New Missed Lines %
src/d.jl 1 98.37%
src/g.jl 2 96.41%
src/cells.jl 6 83.93%
Totals Coverage Status
Change from base Build 246: -0.2%
Covered Lines: 2545
Relevant Lines: 2573

💛 - Coveralls

@giordano
Copy link
Member

giordano commented Aug 2, 2020

Yes, I'm not afraid of removing support for old versions of Julia: they won't enjoy new releases of the package, but the old ones will of course work. I believe the much easier installation and lower maintenance are worth the breakage.

Note that cirrus CI is probably kind of broken. You can just drop it and add freebsd to the operating systems for Travis

@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #14 into master will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   99.22%   98.91%   -0.31%     
==========================================
  Files          27       27              
  Lines        2568     2573       +5     
==========================================
- Hits         2548     2545       -3     
- Misses         20       28       +8     
Impacted Files Coverage Δ
src/SPICE.jl 98.43% <ø> (ø)
src/cells.jl 83.92% <0.00%> (-10.42%) ⬇️
src/g.jl 96.41% <0.00%> (-0.88%) ⬇️
src/c.jl 100.00% <0.00%> (ø)
src/d.jl 98.36% <0.00%> (ø)
src/e.jl 99.19% <0.00%> (ø)
src/f.jl 100.00% <0.00%> (ø)
src/h.jl 100.00% <0.00%> (ø)
src/i.jl 100.00% <0.00%> (ø)
src/l.jl 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2529fa...2a332b5. Read the comment docs.

Project.toml Outdated Show resolved Hide resolved
@helgee
Copy link
Member Author

helgee commented Aug 3, 2020

In principle it would suffice to test on 1.5 and nightly, right?

@giordano
Copy link
Member

giordano commented Aug 3, 2020

I usually test packages with the oldest supported version of Julia (1.3 here) and the latest one (1, which is an alias for the latest stable release in the v1 series)

@giordano
Copy link
Member

giordano commented Aug 3, 2020

...in addition to nightly

@helgee helgee merged commit 5631c85 into master Aug 3, 2020
@helgee helgee deleted the jll branch August 3, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants