Added some Q #4
Merged
Added some Q #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add docstrings |
Pull Request Test Coverage Report for Build 101
💛 - Coveralls |
Pull Request Test Coverage Report for Build 114
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
===========================================
- Coverage 99.75% 82.79% -16.97%
===========================================
Files 21 23 +2
Lines 414 523 +109
===========================================
+ Hits 413 433 +20
- Misses 1 90 +89
Continue to review full report at Codecov.
|
helgee
requested changes
Nov 26, 2018
src/e.jl
Outdated
| handleerror() | ||
| permutedims(r) | ||
|
|
||
| end |
src/q.jl
Outdated
|
|
||
| - [NAIF Documentation](https://naif.jpl.nasa.gov/pub/naif/toolkit_docs/C/cspice/qxq_c.html) | ||
| """ | ||
| qxq(q1,q2...) = qxq(collect(q1),collect(q2)) |
test/m.jl
Outdated
| vecgood = [1., 2., 3.] | ||
| @test mxvg(matrix, vecgood) == [6.,20.] | ||
| vecgood = [1., 2., 3.] | ||
| @test mxvg(matrix, vecgood) == [6.,20.] |
There was a problem hiding this comment.
Just use general Julia syntax, which is matrix * vecgood
test/q.jl
Outdated
|
|
||
| dq = qxq(q, qav) | ||
|
|
||
| #dq = [-0.5 * x for x in dq] |
There was a problem hiding this comment.
Do not comment out code, delete it. Git will take care of it :-)
There was a problem hiding this comment.
Or do something like # TODO: Finish this
test/q.jl
Outdated
|
|
||
| qK = [0.0, 0.0, 0.0, 1.0] | ||
|
|
||
| qIJ=qxq(qI, qJ) |
There was a problem hiding this comment.
Always spaces around = for assignment
test/r.jl
Outdated
| end | ||
|
|
||
|
|
||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.