Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] added subslr, recpgr, reclat, subpnt #9

Merged
merged 8 commits into from
Feb 7, 2019

Conversation

LunarLukas
Copy link
Contributor

added subslr, recpgr, reclat, subpnt
the test function for subslr does not work

@coveralls
Copy link

coveralls commented Jan 21, 2019

Pull Request Test Coverage Report for Build 165

  • 57 of 59 (96.61%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 97.573%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/s.jl 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/s.jl 1 74.14%
Totals Coverage Status
Change from base Build 155: 0.01%
Covered Lines: 965
Relevant Lines: 989

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #9 into master will increase coverage by 0.11%.
The diff coverage is 96.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   97.56%   97.67%   +0.11%     
==========================================
  Files          26       27       +1     
  Lines         944      989      +45     
==========================================
+ Hits          921      966      +45     
  Misses         23       23
Impacted Files Coverage Δ
src/i.jl 100% <100%> (ø)
src/e.jl 100% <100%> (ø) ⬆️
src/r.jl 100% <100%> (ø) ⬆️
src/s.jl 74.13% <92%> (+6.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75bb7f8...37556c0. Read the comment docs.

@LunarLukas LunarLukas changed the title added subslr, recpgr, reclat, subpnt [WIP] added subslr, recpgr, reclat, subpnt Jan 21, 2019
	ilumin
	illumg
	edterm
src/i.jl Outdated Show resolved Hide resolved
src/e.jl Outdated Show resolved Hide resolved
src/i.jl Outdated
method, target, ilusrc, et, fixref, abcorr, obsrvr, spoint, trgepc, srfvec, phase, incdnc, emissn)
handleerror()
trgepc[], srfvec, phase[], incdnc[], emissn[]
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
end
end

test/s.jl Outdated Show resolved Hide resolved
helgee and others added 4 commits February 7, 2019 14:56
Co-Authored-By: LunarLukas <45039609+LunarLukas@users.noreply.github.com>
Co-Authored-By: LunarLukas <45039609+LunarLukas@users.noreply.github.com>
Co-Authored-By: LunarLukas <45039609+LunarLukas@users.noreply.github.com>
@helgee helgee merged commit 7c5a3ca into JuliaAstro:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants