Loosen nanosecond resolution restriction #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7. While resolution is now generally unrestricted, I enforce a minimum measurable time of one picosecond to prevent erroneous negative timings that might arise from inaccuracy in the
estimate_overhead()feature (which is still disabled by default).This breaks JLD deserialization of the
TrialandParameterstypes,so I've provided aI'll have to do a reformatting sweep on the data in BaseBenchmarkReports once the new version of BenchmarkTools lands on the nanosoldier. EDIT: I've decided to hold off on merging this until #15 is resolved.loadoldfunction that usesJLD.readas/JLD.translateto allow deserialization of old data. Is there a better way to automatically do the conversion that doesn't require the explicit use of this extra method? If not,I intend to tag a new version of BenchmarkTools after this is merged, thus the reference to
v0.0.3in the addition to the README.