Fix compatibility with Julia v1.0 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `eachrow` and `isnothing` as they are not in Julia v1.0.
|
Thanks for your PR! Could you add a test? |
|
Yes, sure, I've added a test on the exact output of The test found a bug in the previous bugfix to |
tecosaur
reviewed
Aug 12, 2021
vchuravy
reviewed
Aug 13, 2021
tecosaur
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Julia v1.0, the use of
eachrowandisnothingbreaks the printing of benchmark results as they were only added in v1.1. This PR replaces them with compatible alternatives.