GitHub actions

[ranocha]

I enabled GitHub actions for CI and Documenter. It would be good if someone with more access rights can check this and set the appropriate secrets/settings.

I want to add this to allow more reliable testing, e.g. to bump the compat bound of BenchmarkTools.jl (#124).

[ranocha]

Bump. Is there any interest in this?

[KristofferC]

Yes, thanks! I wonder, is there a way not to get 7 coveralls checks? It feels a bit excessive.

[ranocha]

I wonder, is there a way not to get 7 coveralls checks? It feels a bit excessive.

I don't know... I would really like to get rid of the intermediate runs and only keep coverage/coveralls, but I couldn't find a way to achieve that...

[KristofferC]

Maybe we can switch to codecov then? That seems to only give one check. I think this: https://github.com/KristofferC/NearestNeighbors.jl/blob/2efd998b6bb74d175e6cbbe1c8bc8e775e502f0b/.github/workflows/CI.yml#L45-L48 is the relevant lines that need to be used.

[ranocha]

@KristofferC These lines enable Codecov - I guess somebody needs to enable Codecov on their website?

[ranocha]

Maybe we can switch to codecov then? That seems to only give one check. I think this: https://github.com/KristofferC/NearestNeighbors.jl/blob/2efd998b6bb74d175e6cbbe1c8bc8e775e502f0b/.github/workflows/CI.yml#L45-L48 is the relevant lines that need to be used.

We observed that Codecov and Coveralls report different coverage percentages when collecting data from parallel Julia tests, see https://community.codecov.io/t/code-lines-wrongly-detected-as-executable-in-parallel-jobs-for-a-julia-project/1940. Thus, I think it might be worth keeping the additional information reported by Coveralls

[KristofferC]

These tests are not run in parallel so I think that is no worry.

I think codecov is already active because it has data for the latest commit: https://codecov.io/gh/JuliaCI/PkgBenchmark.jl/commit/21896fc9a4ff5d0d26db086aa7ed72a9f88b1cb9/

[ranocha]

Is there anything left to do for me?

• I would propose to keep Coveralls since additional information doesn't hurt.
• Someone could enable the Codecov integration in PRs if desired (report of the bot).
• Someone should disable Appveyor to remove the failing CI test.

[KristofferC]

I've removed AV and coveralls. Additional information does hurt if is too noisy.

Thanks for the help with this!