Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix show for BenchmarkConfig with id being nothing (fixes #78) #80

Merged
merged 2 commits into from Jul 4, 2019
Merged

fix show for BenchmarkConfig with id being nothing (fixes #78) #80

merged 2 commits into from Jul 4, 2019

Conversation

johnnychen94
Copy link
Contributor

fix issue #78

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.6%) to 77.186% when pulling 758f788 on johnnychen94:master into 437a973 on JuliaCI:master.

@coveralls
Copy link

coveralls commented Jul 4, 2019 •
edited

Coverage Status

Coverage decreased (-5.6%) to 77.186% when pulling ca2e4a3 on johnnychen94:master into 437a973 on JuliaCI:master.

KristofferC
KristofferC reviewed Jul 4, 2019
View reviewed changes
src/benchmarkconfig.jl Outdated Show resolved Hide resolved
@johnnychen94 @KristofferC
Update src/benchmarkconfig.jl
ca2e4a3 
Co-Authored-By: Kristoffer Carlsson <kristoffer.carlsson@chalmers.se>
@KristofferC KristofferC merged commit 144976d into JuliaCI:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnnychen94 @coveralls @KristofferC