Add Online plugin #113
Add Online plugin #113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=========================================
- Coverage 92.13% 91.1% -1.04%
=========================================
Files 15 16 +1
Lines 318 371 +53
=========================================
+ Hits 293 338 +45
- Misses 25 33 +8
Continue to review full report at Codecov.
|
|
Is this tied to Github? If so I do not think it should have such a generic name as |
|
Yes it is. What should I call it? |
|
Bump |
|
Hi, I'll have a look sometime this week or weekend, I've been busy. |
|
Np. The rewrite looks great! |
There was a problem hiding this comment.
I started reviewing specifics but I realized that pointing out code style stuff is really silly of me, I'll just change that stuff myself. Here are some more high-level comments:
The name is fine but we can make this less specific to the GitHub+Travis+Documenter use case. Something along these lines:
put_online(t, p) = nothing
put_online(t, p::Git) = # Create Git{Hub,Lab,etc.} repo
put_online(t, p::Documenter{TravisCI}) = # Create DOCUMENTER_KEY
# And so on for other plugins that can have some online component. This is extensible by outside plugins too.
hook(::Online, t::Template, ::AbstractString) = foreach(p -> put_online(t, p), t.plugins)I'd prefer to keep the online settings stuff out of Template, and in Online.
Maybe something like:
struct Online fields... end
Online(settings::AbstractString) = # get the options from this file
Online() = Online(some_default_path)The default file could be managed by PkgTemplates (stored somewhere in the user's installation). with an interactive prompt to create it the first time.
I'd be happy to take on that extra work myself, since the groundwork is already here thanks to you. Maybe I could pull this into a separate branch and work from there for a while?
| ), | ||
| body = body | ||
| ) | ||
| if response.status >= 300 |
There was a problem hiding this comment.
This code never gets reached, the HTTP request itself will raise an exception.
| if response.status >= 300 | ||
| error("$(response.status) $(response.statustext): $(String(response.body))") | ||
| end | ||
| response.body |
There was a problem hiding this comment.
| response.body | |
| return response.body |
|
Sure, feel free to change it however you want |
|
So...I think github actions are amazing and basically make this ancient tech. Feel free to reopen if you want. |
|
Well, I've updated OnlinePackage to work with GitHub actions |
|
@christopher-dG it looks like documenter doesn't require a separate SSH key anymore, and neither does codecov, but CompatHelper does, so I think this is still useful. Do you want me to try to revive the PR? |
Updates #79 to the new infrastructure