Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PkgTemplates work on 1.0 #19

Merged
merged 23 commits into from
Sep 26, 2018
Merged

Make PkgTemplates work on 1.0 #19

merged 23 commits into from
Sep 26, 2018

Conversation

christopher-dG
Copy link
Member

@christopher-dG christopher-dG commented Sep 24, 2018

This doesn't change much if any of the package functionality, it just makes it run and all the test pass. So it's basically creating packages for 0.6. Next up is to use Pkg.generate etc.
One other change is with the default plugin file templates, there was a bug fixed in Mustache which lets us write much more clearly.

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #19 into master will decrease coverage by 0.02%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   98.67%   98.64%   -0.03%     
==========================================
  Files          11       11              
  Lines         378      296      -82     
==========================================
- Hits          373      292      -81     
+ Misses          5        4       -1
Impacted Files Coverage Δ
src/plugins/travisci.jl 100% <ø> (ø) ⬆️
src/plugins/coveralls.jl 100% <ø> (ø) ⬆️
src/plugins/codecov.jl 100% <ø> (ø) ⬆️
src/plugins/appveyor.jl 100% <ø> (ø) ⬆️
src/plugins/gitlabci.jl 100% <ø> (ø) ⬆️
src/plugin.jl 100% <100%> (ø) ⬆️
src/template.jl 97.24% <100%> (-0.55%) ⬇️
src/generate.jl 100% <100%> (+1.02%) ⬆️
src/licenses.jl 100% <100%> (ø) ⬆️
src/plugins/documenter.jl 96.42% <83.33%> (-0.72%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c7875...50ed265. Read the comment docs.

.travis.yml Show resolved Hide resolved
.travis.yml Outdated
- julia -e 'Pkg.clone(pwd()); Pkg.test("PkgTemplates"; coverage=true)'
before_script:
- git config --global user.name "Chris de Graaf"
- git config --global user.email "chrisadegraaf@gmail.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should add a comment explaining. When you LibGit2.commit without these options, it raises an exception, and Travis OSX and AppVeyor both don't have this preconfigured (interestingly, it works on Linux).
(A couple of commits are made as part of package generation)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you may not want to expose your email address in the commit history. Up to you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it's all over the commit history but I will remove it from the CI files 😅. Editing that commit.

{{#COVERALLS}}
- C:\projects\julia\bin\julia -e "cd(Pkg.dir(\"{{PKGNAME}}\")); Pkg.add(\"Coverage\"); using Coverage; Coveralls.submit(process_folder())"
{{/COVERALLS}}
{{/AFTER}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default appveyor.yml script should be now based upon the Appveyor.jl package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'm going to change this in the next PR which will update the real functionality.

@ararslan ararslan deleted the cdg/1.0ify branch September 26, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants