Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash in "Official https://julialang.org/ release" #348

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LilithHafner
Copy link

@LilithHafner
Copy link
Author

We should only make this change in Julia 1.12+ because previous versions expect Base.TAGGED_RELEASE_BANNER == "Official https://julialang.org/ release"

@DilumAluthge
Copy link
Member

We should only make this change in Julia 1.12+

Probably the simplest way is to just have an if in this Bash script, and do something like sed or grep the VERSION file.

@gbaraldi What do you think?

The more complicated way would be to make some release- branches on this repo (the julia-buildkite repo). That's a more complex approach that brings more overhead.

@LilithHafner
Copy link
Author

Lovely, bash is my favorite programming language!

@LilithHafner
Copy link
Author

grep -P is not supported. Refactoring.

@LilithHafner
Copy link
Author

Make Options:
 -> -j4
 -> VERBOSE=1
 -> TAGGED_RELEASE_BANNER=Official https://julialang.org release

Seems to be working. Do we test building old versions of Julia in CI here?

@DilumAluthge
Copy link
Member

Do we test building old versions of Julia in CI here?

Currently, in this repo, PRs against the main branch of this repo will only test building the master branch of Julia.

It is possible to do a test against a different branch of Julia. I don't remember the steps off the top of my head, but @gbaraldi might remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants