Allow "[profile default]" in .aws/config #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable. Needs a test though |
The awscli allows either a section [default] or [profile default] in the aws config file.
c42f
force-pushed
the
cjf/config-allow-profile-default
branch
from
2b30d5b
to
21dc437
Compare
|
Test added. |
mattBrzezinski
approved these changes
Oct 12, 2021
Comment on lines
+23
to
+35
| @testset "default profile section names" begin | ||
| allowed_default_sections = ["default", "profile default"] | ||
| mktemp() do config_path, _ | ||
| for default_section_str in allowed_default_sections | ||
| config = """ | ||
| [$default_section_str] | ||
| region = xx-yy-1 | ||
| """ | ||
| write(config_path, config) | ||
| @test aws_get_region(; profile="default", config=config_path) == "xx-yy-1" | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
I believe this is the proper syntax.
Suggested change
| @testset "default profile section names" begin | |
| allowed_default_sections = ["default", "profile default"] | |
| mktemp() do config_path, _ | |
| for default_section_str in allowed_default_sections | |
| config = """ | |
| [$default_section_str] | |
| region = xx-yy-1 | |
| """ | |
| write(config_path, config) | |
| @test aws_get_region(; profile="default", config=config_path) == "xx-yy-1" | |
| end | |
| end | |
| end | |
| @testset "$(profile) section names" for profile in ["default", "profile_default"] | |
| mktemp() do config_path, _ | |
| config = """ | |
| [$(profile)] | |
| region = xx-yy-1 | |
| """ | |
| write(config_path, config) | |
| @test aws_get_region(; profile="default", config=config_path) == "xx-yy-1" | |
| end | |
| end | |
| end |
There was a problem hiding this comment.
Sure, if you want two test sets with a single test in them each, feel free to commit something like this.
Note, however that this patch is wrong because we want to test profile == "profile default" (not "profile_default" with an underscore).
There was a problem hiding this comment.
It's nbd, I just find different cases in a @testset are easier to debug.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The awscli allows either a section
[default]or[profile default]inthe aws config file.
I had
[profile default]in my config and was surprised when this worked with awscli but not with AWS.jl.