Add AWSException fallback to replicate old constructor #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Oct 20, 2021
495: Add AWSException fallback to replicate old constructor r=mattBrzezinski a=iamed2 Fixes invenia/CloudWatchLogs.jl#40 When AWSResponse changes went in, a new field was added. CloudWatchLogs.jl tests relied on the default constructor, so when a field was added, tests broke. This adds a fallback that replicates the old constructor. It's also a reasonable fallback I think, given that the final field is optional (could be `nothing`). Co-authored-by: Eric Davies <iamed2@gmail.com>
|
Build failed: |
|
Build succeeded when retried |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes invenia/CloudWatchLogs.jl#40
When AWSResponse changes went in, a new field was added. CloudWatchLogs.jl tests relied on the default constructor, so when a field was added, tests broke. This adds a fallback that replicates the old constructor. It's also a reasonable fallback I think, given that the final field is optional (could be
nothing).