Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTP.jl 1.0 #560
Support HTTP.jl 1.0 #560
Changes from all commits
3172add
18a34ee
0ad1f5c
ed0f396
2f7bee3
21f027f
7ba8fb7
26f547e
1a56edc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this broke some things for the Downloads backend, because it assumes the response is coming from HTTP.jl and has
method
andtarget
fields, whereas before it just wrapped the response, which could be coming from Downloads.jl and may not have those fields. I guess the AWS tests aren't enough to check this case, but I saw when adding Downloads.jl tests to AWSS3: JuliaCloud/AWSS3.jl#262. See https://github.com/JuliaCloud/AWSS3.jl/runs/7409333758?check_suite_focus=true#step:6:388.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the DownloadsBackend-created
HTTP.Response
that's returned just include the request here?