Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HTTP and MbedTLS compatibilities #35

Closed
wants to merge 4 commits into from

Conversation

snisher
Copy link

@snisher snisher commented Jan 13, 2021

Haven't tested locally...

Haven't tested locally...
Project.toml Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 13, 2021

Codecov Report

Merging #35 (59f4594) into master (ace686c) will decrease coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #35      +/-   ##
=========================================
- Coverage    8.15%   7.45%   -0.70%     
=========================================
  Files          11      11              
  Lines         429     429              
=========================================
- Hits           35      32       -3     
- Misses        394     397       +3     
Impacted Files Coverage Δ
src/api/api.jl 19.84% <0.00%> (-2.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace686c...a062cf3. Read the comment docs.

new MbedTLS needs > 1.3
@snisher
Copy link
Author

snisher commented Jan 13, 2021

Works for me locally.

@mattBrzezinski
Copy link
Member

These changes will no longer allow Julia 1.0 to work with this package. Although it's not a particularly used package AFAIK I think we should still be supporting the Julia LTS version. We can use HTTP@0.9, but keep MbedTLS@0.6.

Unless there is a strong argument here for upgrading MbedTLS, I think keep this as is until the next LTS comes out (soonTM) keeps this package available to as many people as possible.

@snisher
Copy link
Author

snisher commented Jan 14, 2021

Makes sense. MbedTLS < 1.0 has a build script so isn't easily compatible with compiling an app with PackageCompiler, but I can use my local version until the new LTS. Thanks!

@YoungFaithful
Copy link

I would love to see the update HTTP@0.9 be shipped. Should I add a new merge request with it?

@nlw0
Copy link
Collaborator

nlw0 commented Jun 6, 2023

Since all these dependencies have been upgraded in other PRs, I'm closing this.

@nlw0 nlw0 closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants