Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated doc for construction of DefaultDict #364

Closed
scls19fr opened this issue Jan 7, 2018 · 0 comments
Closed

Deprecated doc for construction of DefaultDict #364

scls19fr opened this issue Jan 7, 2018 · 0 comments

Comments

@scls19fr
Copy link
Member

scls19fr commented Jan 7, 2018

Hello,

I noticed in doc the following construction of DefaultDict

https://github.com/JuliaCollections/DataStructures.jl/blame/c31f17f0d0dead44ae7766b36fd880dcae666a9d/doc/src/default_dict.md#L18

but this kind of construction is deprecated so it shouldn't be in doc

julia> DefaultDict(String, Int, 0)
WARNING: DefaultDict(::Type{K}, ::Type{V}, default) where {K, V} is deprecated, use DefaultDict{K, V}(default) instead.
Stacktrace:
 [1] depwarn(::String, ::Symbol) at .\deprecated.jl:70
 [2] DataStructures.DefaultDict(::Type{String}, ::Type{Int64}, ::Int64) at .\deprecated.jl:57
 [3] eval(::Module, ::Any) at .\boot.jl:235
 [4] eval_user_input(::Any, ::Base.REPL.REPLBackend) at .\REPL.jl:66
 [5] macro expansion at .\REPL.jl:97 [inlined]
 [6] (::Base.REPL.##1#2{Base.REPL.REPLBackend})() at .\event.jl:73
while loading no file, in expression starting on line 0
DataStructures.DefaultDict{String,Int64,Int64} with 0 entries

julia> DefaultDict{String, Int}(0)
DataStructures.DefaultDict{String,Int64,Int64} with 0 entries

This issue is comparable to #340

Kind regards

@scls19fr scls19fr changed the title Deprecated doc for DefaultDict construction Deprecated doc for construction of DefaultDict Jan 7, 2018
scls19fr added a commit to scls19fr/DataStructures.jl that referenced this issue Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant