Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for FenwickTree #491

Closed
eulerkochy opened this issue Apr 8, 2019 · 4 comments
Closed

Add documentation for FenwickTree #491

eulerkochy opened this issue Apr 8, 2019 · 4 comments

Comments

@eulerkochy
Copy link
Member

With #485 in the master, there is a need for documenting this DS.

@kmsquire
Copy link
Member

kmsquire commented Apr 8, 2019

Whoops... should have asked you to do that before merging. Oh, well, if you could add some documentation, that would be great--thanks!

@eulerkochy
Copy link
Member Author

Ok, cool!

@sambitdash
Copy link
Contributor

I feel the data structure should be called "BinaryIndexedTree" or something similar. In general the package contains very few DS that are named after the inventor. @eulerkochy and @kmsquire, please suggest if that change is useful.

@eulerkochy
Copy link
Member Author

Why not honour the inventor when there is a scope of doing so! imo, it hardly would matter if we rename it, as both terms are quite interchangebly, plus it has been mentioned in the implementation of the DS.

struct FenwickTree{T}
    bi_tree::Vector{T} #bi_tree is shorthand for Binary Indexed Tree, an alternative name for Fenwick Tree
    n::Int
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants