Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for FenwickTree #492

Merged
merged 5 commits into from Apr 9, 2019

Conversation

eulerkochy
Copy link
Member

Fix #491 and a positional change in docstring in fenwick.jl

@oxinabox
Copy link
Member

oxinabox commented Apr 8, 2019

Add to list of all data structures, in the readme, as well?

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #492 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files          31       31           
  Lines        2372     2372           
=======================================
  Hits         2119     2119           
  Misses        253      253
Impacted Files Coverage Δ
src/fenwick.jl 92.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0cc5d0...e6167df. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #492 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files          31       31           
  Lines        2372     2372           
=======================================
  Hits         2119     2119           
  Misses        253      253
Impacted Files Coverage Δ
src/fenwick.jl 92.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0cc5d0...b274af6. Read the comment docs.

@eulerkochy
Copy link
Member Author

@kmsquire review?

Copy link
Member

@kmsquire kmsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one suggested change, LGTM!

README.md Outdated Show resolved Hide resolved
Co-Authored-By: eulerkochy <kc99.kol@gmail.com>
@kmsquire kmsquire merged commit 640379b into JuliaCollections:master Apr 9, 2019
@eulerkochy eulerkochy mentioned this pull request Jul 4, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants