Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove straggling references to Associative #441

Merged
merged 1 commit into from Aug 24, 2018

Conversation

kmsquire
Copy link
Member

Fixes #351.

@kmsquire kmsquire requested a review from scls19fr August 24, 2018 07:16
@oxinabox
Copy link
Member

Title is wrong, these changes are mostly to how markdown formatting styles are use.
With 1 or 2 removals of AbstractDict
But LGTM

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #441 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #441      +/-   ##
=========================================
+ Coverage   98.19%   98.2%   +0.01%     
=========================================
  Files          30      30              
  Lines        1658    1669      +11     
=========================================
+ Hits         1628    1639      +11     
  Misses         30      30
Impacted Files Coverage Δ
src/circular_buffer.jl 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd2322...ef4760b. Read the comment docs.

@scls19fr
Copy link
Member

Thanks @kmsquire

@scls19fr scls19fr merged commit 00831b0 into master Aug 24, 2018
@kmsquire
Copy link
Member Author

Title is wrong, these changes are mostly to how markdown formatting styles are use.
With 1 or 2 removals of AbstractDict

Sorry, I had auto formatting on save turned on, and didn’t pay attention to the diff uploaded. Whoops! The only changes I consciously made were the ones related to the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants