Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate ClassifierCollection #524

Merged
merged 2 commits into from Oct 29, 2019
Merged

deprecate ClassifierCollection #524

merged 2 commits into from Oct 29, 2019

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Aug 14, 2019

First part of #496

I don't know what to recommend using instead.
Probably a DefaultDict(Collection)?

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #524 into master will decrease coverage by 5.51%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   93.39%   87.88%   -5.52%     
==========================================
  Files          32       32              
  Lines        2544     2105     -439     
==========================================
- Hits         2376     1850     -526     
- Misses        168      255      +87
Impacted Files Coverage Δ
src/classified_collections.jl 75% <100%> (-15%) ⬇️
src/delegate.jl 50% <0%> (-41.67%) ⬇️
src/container_loops.jl 27.5% <0%> (-23.72%) ⬇️
src/heaps/minmax_heap.jl 91.76% <0%> (-8.24%) ⬇️
src/heaps.jl 92% <0%> (-8%) ⬇️
src/heaps/arrays_as_heaps.jl 86.2% <0%> (-7.74%) ⬇️
src/multi_dict.jl 67.46% <0%> (-7.54%) ⬇️
src/tokens2.jl 92.59% <0%> (-7.41%) ⬇️
src/sorted_set.jl 82.94% <0%> (-6.82%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c2c3b3...18d76fb. Read the comment docs.

@oxinabox
Copy link
Member Author

@kmsquire can I request a review?
I would like to get this into 0.17.x so can remove in 0.18

Copy link
Member

@kmsquire kmsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but I have no problem with the depreciation.

src/classified_collections.jl Outdated Show resolved Hide resolved
@oxinabox oxinabox merged commit 6fa0d12 into master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants