Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the behavior of RobinDict for get, getkey, haskey, getindex #629

Merged
merged 2 commits into from Jun 14, 2020
Merged

Correct the behavior of RobinDict for get, getkey, haskey, getindex #629

merged 2 commits into from Jun 14, 2020

Conversation

eulerkochy
Copy link
Member

Match to the behavior of Base.Dict in these scenarios.
Fixes #628

oxinabox
oxinabox approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increment release in Project.toml, before merging.
or increment and suffix with -DEV if you want to batch the release of these with the other upcoming RobinDict changes

@eulerkochy eulerkochy merged commit 787ac72 into master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RobinDict: InexactError is thrown in place of KeyError
2 participants
@eulerkochy @oxinabox