Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MutableBinaryHeap, issue similar to #686 #720

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Fix MutableBinaryHeap, issue similar to #686 #720

merged 1 commit into from
Jan 18, 2021

Conversation

dm3
Copy link
Contributor

@dm3 dm3 commented Jan 18, 2021

Issue with Base.Order.ReverseOrdering. Mirror of #686, only related to a MutableBinaryHeap implementation. Depends on JuliaLang/julia#37822.

oxinabox
oxinabox approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
Do you need this backported so the fix is available in 0.18?
I don't know when 0.19 will be released.

@oxinabox oxinabox merged commit f46e7d2 into JuliaCollections:master Jan 18, 2021
@dm3
Copy link
Contributor Author

dm3 commented Jan 19, 2021

Sure, would be nice to have in 0.18!

@oxinabox
Copy link
Member

ok, I will make it so

@oxinabox oxinabox mentioned this pull request Jan 19, 2021
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dm3 @oxinabox