-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Update OrderedDict, OrderedSet constructors to take iterables (fixes #50, #64, #67) #77
Conversation
I guess I should add some more tests... |
Also: * Minor HashDict cleanups
* Tests should pass on v0.3, v0.4
868dc00
to
e51ccc6
Compare
That's all I plan to do for now. I added tests for This is a breaking change, in the sense that some constructors for the old version of At any rate, I'm going to bump the minor number, as opposed to the patch number, and make an announcement on julia-users. |
Actually, I take that back--this isn't a breaking change. The old functionality is deprecated, and the new functionality is available. Does that warrant a bump in minor number? |
I just bumped the patch. |
Eventually, these data structures might be made moot, if JuliaLang/julia#10116 is merged. But for now, it would at least be worthwhile matching
Dict
andSet
construction in base in Julia v0.3.I plan to merge this in a day or two, pending any comments.