Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Update OrderedDict, OrderedSet constructors to take iterables (fixes #50, #64, #67) #77

Merged
merged 2 commits into from
Mar 5, 2015

Conversation

kmsquire
Copy link
Member

@kmsquire kmsquire commented Mar 4, 2015

  • Plus minor related changes

Eventually, these data structures might be made moot, if JuliaLang/julia#10116 is merged. But for now, it would at least be worthwhile matching Dict and Set construction in base in Julia v0.3.

I plan to merge this in a day or two, pending any comments.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.93%) to 81.67% when pulling 91ea71c on ordered_cleanup into 1d1afe5 on master.

@kmsquire
Copy link
Member Author

kmsquire commented Mar 4, 2015

I guess I should add some more tests...

@kmsquire kmsquire changed the title Update OrderedDict, OrderedSet constructors to take iterables (fixes #50) Update OrderedDict, OrderedSet constructors to take iterables (fixes #50, #67) Mar 4, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.36%) to 81.24% when pulling 7a4c643 on ordered_cleanup into 1d1afe5 on master.

@kmsquire kmsquire changed the title Update OrderedDict, OrderedSet constructors to take iterables (fixes #50, #67) Update OrderedDict, OrderedSet constructors to take iterables (fixes #50, #64, #67) Mar 4, 2015
@kmsquire kmsquire changed the title Update OrderedDict, OrderedSet constructors to take iterables (fixes #50, #64, #67) RFC: Update OrderedDict, OrderedSet constructors to take iterables (fixes #50, #64, #67) Mar 4, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.35%) to 81.25% when pulling a284f97 on ordered_cleanup into 1d1afe5 on master.

@kmsquire
Copy link
Member Author

kmsquire commented Mar 5, 2015

That's all I plan to do for now. I added tests for OrderedDicts and OrderedSets, mostly by copying and modifying Dict and Set tests from Base. This actually uncovered a couple of bugs (tests are useful!), which I fixed as well.

This is a breaking change, in the sense that some constructors for the old version of OrderedDicts and OrderedSets no longer work. This does bring those mostly up to par with the constructors in v0.3, though, so I doubt many people will be affected.

At any rate, I'm going to bump the minor number, as opposed to the patch number, and make an announcement on julia-users.

kmsquire added a commit that referenced this pull request Mar 5, 2015
RFC: Update OrderedDict, OrderedSet constructors to take iterables (fixes #50, #64, #67)
@kmsquire kmsquire merged commit fed1448 into master Mar 5, 2015
@kmsquire kmsquire deleted the ordered_cleanup branch March 5, 2015 16:17
@kmsquire
Copy link
Member Author

kmsquire commented Mar 5, 2015

Actually, I take that back--this isn't a breaking change. The old functionality is deprecated, and the new functionality is available. Does that warrant a bump in minor number?

@kmsquire
Copy link
Member Author

kmsquire commented Mar 7, 2015

I just bumped the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants