-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type piracy causing warnings #10
Comments
Ah, it looks like that definition was just moved into this package, so is the plan to delete it from DataStructures.jl ? |
Yes, it's just not merged yet. See JuliaCollections/DataStructures.jl#448 |
Yeah, this is dumping errors out everywhere for me. Would be great to have this fixed soon. Thanks! |
It's been merged and tagged, just waiting for METADATA. Sorry for the inconvenience; I don't think there's a way for our current package manager to fix this by doing both updates simultaneously, at least not without modifying the .travis.yml script to install a particular branch. |
This package and DataStructures both commit some type-piracy by trying to define
sort(::Dict)
. That used to silently work OK, but now it results in warnings when both packages are loaded, since the pirated definitions get overloaded by whatever package is loaded second.Maybe OrderedCollections should not define that
sort
method?The text was updated successfully, but these errors were encountered: