Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type piracy causing warnings #10

Closed
rdeits opened this issue Sep 20, 2018 · 4 comments
Closed

Type piracy causing warnings #10

rdeits opened this issue Sep 20, 2018 · 4 comments

Comments

@rdeits
Copy link

rdeits commented Sep 20, 2018

This package and DataStructures both commit some type-piracy by trying to define sort(::Dict). That used to silently work OK, but now it results in warnings when both packages are loaded, since the pirated definitions get overloaded by whatever package is loaded second.

Maybe OrderedCollections should not define that sort method?

@rdeits
Copy link
Author

rdeits commented Sep 20, 2018

Ah, it looks like that definition was just moved into this package, so is the plan to delete it from DataStructures.jl ?

@timholy
Copy link
Member

timholy commented Sep 20, 2018

Yes, it's just not merged yet. See JuliaCollections/DataStructures.jl#448

@tlnagy
Copy link

tlnagy commented Sep 20, 2018

Yeah, this is dumping errors out everywhere for me. Would be great to have this fixed soon. Thanks!

@timholy
Copy link
Member

timholy commented Sep 21, 2018

It's been merged and tagged, just waiting for METADATA. Sorry for the inconvenience; I don't think there's a way for our current package manager to fix this by doing both updates simultaneously, at least not without modifying the .travis.yml script to install a particular branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants