Once Base defines radix sort, use that for ::RadixSortAlg #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A major motivation for this is that Base.Sort.Float is internal and likely to be removed in JuliaLang/julia#47383, which causes build errors in this implementation of radix sort. |
I'm not aware of any users that actually pass ts here, so there is not much reason for base to support receiving scratch space in this way.
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 96.51% 95.95% -0.56%
==========================================
Files 1 1
Lines 344 346 +2
==========================================
Hits 332 332
- Misses 12 14 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'd like to merge and release this before JuliaLang/julia#47383 to avoid breaking SortingAlgorithms and its two thousand dependants on nightly. Would someone be willing to give this a review? |
oscardssmith
approved these changes
Nov 11, 2022
Merged
|
@LilithHafner could you check my PR here JuliaRegistries/General#85431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once Base adds radix sort to the default dispatch, make
sort!(..., ::RadixSortAlg, ...)fallback to the default algorithm. Also, move radix sort to the end of the file because it no longer needs to be as actively maintained.Closes more than half the open issues in this repo!
Fixes #56
Fixes #52
Fixes #50
Fixes #48
Fixes #26
Closes #34, moving it into the scope of JuliaLang/Julia, to be fixed in JuliaLang/julia#47383
Closes #38, moving it into the scope of JuliaLang/Julia