Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecations for Julia 1 #91

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Deprecations for Julia 1 #91

wants to merge 10 commits into from

Conversation

aminya
Copy link

@aminya aminya commented Aug 14, 2019 •
edited
Loading

WIP

@aminya aminya mentioned this pull request Sep 13, 2019
Open
@aminya
Copy link
Author

aminya commented Nov 28, 2019

If anyone wants to work on this, they responded to my old issue:

julia-vscode/CSTParser.jl#102

I am trying to upgrade Deprecations.jl for FemtoCleaner. In Deprecations code CSTParser.BinarySyntaxOpCall is used a lot like here.

I found its definition here.

What has happened to this in recent versions?

Answer:

Dedicated expression datatypes (e.g. BinarySyntaxOpCall, UnaryOpCall, etc.) were replaced by a single expression type (EXPR). The 'type' of expressions are now stored in the .typ field which should be accessed using CSTParser.typof(x::EXPR).

The change was made for increasing parsing speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aminya