Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of freqresp for state space systems #108

Closed
olof3 opened this issue Aug 29, 2017 · 0 comments
Closed

Improve efficiency of freqresp for state space systems #108

olof3 opened this issue Aug 29, 2017 · 0 comments

Comments

@olof3
Copy link
Contributor

olof3 commented Aug 29, 2017

There is old code the improve the efficiency of freqresp for state space systems, but it is not used.

# Implements algorithm found in:
# Laub, A.J., "Efficient Multivariable Frequency Response Computations",
# IEEE Transactions on Automatic Control, AC-26 (1981), pp. 407-408.
function _preprocess_for_freqresp(sys::StateSpace)
    A, B, C, D = sys.A, sys.B, sys.C, sys.D
    F = hessfact(A)
    H = F[:H]::Matrix{Float64}
    T = full(F[:Q])
    P = C*T
    Q = T\B
    StateSpace(H, Q, P, D, sys.Ts, sys.statenames, sys.inputnames,
        sys.outputnames)
end

Would be good to include the code. Would be good to improve the test coverage of freqresp at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants