Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append on DelayLtiSystem does not works #879

Closed
franckgaga opened this issue Oct 4, 2023 · 2 comments · Fixed by #892
Closed

append on DelayLtiSystem does not works #879

franckgaga opened this issue Oct 4, 2023 · 2 comments · Fixed by #892

Comments

@franckgaga
Copy link

Hi,

Here is a minor bug report. If I do:

append(tf(1, [10, 1])*delay(3),tf(2, [12, 1])*delay(5))

it results in:

ERROR: type DelayLtiSystem has no field A
Stacktrace:
 [1] getproperty(sys::DelayLtiSystem{Float64, Float64}, s::Symbol)
   @ ControlSystemsBase ~/.julia/packages/ControlSystemsBase/CUXI9/src/types/Lti.jl:70
 [2] (::ControlSystemsBase.var"#116#126")(s::DelayLtiSystem{Float64, Float64})
   @ ControlSystemsBase ./none:0
 [3] iterate(::Base.Generator{Tuple{DelayLtiSystem{Float64, Float64}, DelayLtiSystem{Float64, Float64}}, ControlSystemsBase.var"#116#126"})
   @ Base ./generator.jl:47
 [4] blockdiag(anything::Base.Generator{Tuple{DelayLtiSystem{Float64, Float64}, DelayLtiSystem{Float64, Float64}}, ControlSystemsBase.var"#116#126"})
   @ ControlSystemsBase ~/.julia/packages/ControlSystemsBase/CUXI9/src/connections.jl:209
 [5] append(::DelayLtiSystem{Float64, Float64}, ::DelayLtiSystem{Float64, Float64})
   @ ControlSystemsBase ~/.julia/packages/ControlSystemsBase/CUXI9/src/types/LFTSystem.jl:117
 [6] top-level scope
   @ REPL[52]:1

but this works as intended:

[tf(0) tf(1, [10, 1])*delay(3); tf(0) tf(2, [12, 1])*delay(5)]

Thanks !

Francis

@franckgaga
Copy link
Author

Thanks Fredrik!

@baggepinnen
Copy link
Member

Thanks for the report 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants