Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic types #118

Merged
merged 120 commits into from
Sep 2, 2018
Merged

Generic types #118

merged 120 commits into from
Sep 2, 2018

Conversation

baggepinnen
Copy link
Member

@baggepinnen baggepinnen commented Jan 31, 2018

Major overhaul of types. All LTISystem types now accept arbitrary array types, e.g., TrackedArrays, GPUArrays or Matrix{DualNumber}. WIP PR created to trigger tests

EDIT by @mfalt : Since tests pass now, we should look through these things before pulling:

  • Decide on a printing format and update print tests
  • Fix so systems almost 0 are zero?
  • Define proper constructors for zpk/tf ?
  • eltype(sys) should match typeof(sys[1,1])
  • Review changes and fix comments
  • Look through TODOs in code
  • Check coverage to see if we introduced code that is not needed/tested
  • Manually test plots or activate plots tests
  • Printing of complex systems doesnt look right
  • Fix hvcat, it makes Base.hvcat type unstable...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants