Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: C2d single returnval #436

Merged
merged 12 commits into from
Jan 27, 2021
Merged

Conversation

olof3
Copy link
Contributor

@olof3 olof3 commented Jan 25, 2021

Fixes #412

Also stripped white spaces in tests for printing transfer functions, in order to make tests pass on nightly. Should at least be good enough for now, see #423.

Made some minor modifications to testing (it was essentially tested that we got the wrong result for the wrong input, which didn't seem meaningful to test).

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #436 (fc5a87c) into master (6249cba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   82.88%   82.89%           
=======================================
  Files          31       31           
  Lines        2857     2858    +1     
=======================================
+ Hits         2368     2369    +1     
  Misses        489      489           
Impacted Files Coverage Δ
src/ControlSystems.jl 100.00% <ø> (ø)
src/delay_systems.jl 86.56% <100.00%> (ø)
src/discrete.jl 84.68% <100.00%> (+0.13%) ⬆️
src/timeresp.jl 91.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6249cba...fc5a87c. Read the comment docs.

@olof3 olof3 requested a review from mfalt January 26, 2021 10:22
@baggepinnen baggepinnen merged commit c680b68 into JuliaControl:master Jan 27, 2021
@mfalt mfalt added the breaking Breaking change! Update news and tag version number. label Jan 27, 2021
@baggepinnen baggepinnen added the v1 Issues to resolve before releasing v1 label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change! Update news and tag version number. v1 Issues to resolve before releasing v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

separate c2d function for returning x0map
3 participants