Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't convert type of time vector #697

Merged
merged 1 commit into from
Jun 23, 2022
Merged

don't convert type of time vector #697

merged 1 commit into from
Jun 23, 2022

Conversation

baggepinnen
Copy link
Member

Because it fails if T is a type that don't support nextfloat and AbstractFloat. The user now has direct control over t which is more useful.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 8/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.043 Reference New
❌ 0.059 Reference New
✔️ 0.01 Reference New

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #697 (76df370) into master (7ba2598) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files          35       35           
  Lines        3601     3601           
=======================================
  Hits         3154     3154           
  Misses        447      447           
Impacted Files Coverage Δ
src/timeresp.jl 90.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba2598...76df370. Read the comment docs.

@baggepinnen baggepinnen merged commit 20169a8 into master Jun 23, 2022
@baggepinnen baggepinnen deleted the ttype branch June 23, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants