Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time-scaling function. #703

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Add time-scaling function. #703

merged 2 commits into from
Jul 2, 2022

Conversation

baggepinnen
Copy link
Member

@baggepinnen baggepinnen commented Jul 1, 2022

The added function time_scale changes the time unit of a system, for example, from seconds to microseconds. Modeling on the correct time scale is important for numerical performance, in particular for continuous-time simulations.

Closes #702

@baggepinnen baggepinnen changed the title Timescale Add time-scaling function. Jul 1, 2022
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 8/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.043 Reference New
❌ 0.059 Reference New
✔️ 0.01 Reference New

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 8/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.043 Reference New
❌ 0.059 Reference New
✔️ 0.01 Reference New

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 8/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.043 Reference New
❌ 0.059 Reference New
✔️ 0.01 Reference New

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #703 (c45c7ef) into master (308434d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage   87.88%   87.91%   +0.03%     
==========================================
  Files          35       35              
  Lines        3614     3624      +10     
==========================================
+ Hits         3176     3186      +10     
  Misses        438      438              
Impacted Files Coverage Δ
src/ControlSystems.jl 100.00% <ø> (ø)
src/hammerstein_weiner.jl 92.12% <ø> (ø)
src/matrix_comps.jl 93.28% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308434d...c45c7ef. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic time scaling
2 participants