Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a number of missing tests #707

Merged
merged 1 commit into from
Jul 5, 2022
Merged

add a number of missing tests #707

merged 1 commit into from
Jul 5, 2022

Conversation

baggepinnen
Copy link
Member

No description provided.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 8/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.043 Reference New
❌ 0.059 Reference New
✔️ 0.01 Reference New

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #707 (c916f76) into master (53a1864) will increase coverage by 0.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
+ Coverage   87.92%   88.43%   +0.51%     
==========================================
  Files          35       35              
  Lines        3628     3624       -4     
==========================================
+ Hits         3190     3205      +15     
+ Misses        438      419      -19     
Impacted Files Coverage Δ
src/types/SisoTfTypes/SisoRational.jl 93.67% <ø> (+14.15%) ⬆️
src/types/StateSpace.jl 90.82% <0.00%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a1864...c916f76. Read the comment docs.

@baggepinnen baggepinnen merged commit afe5131 into master Jul 5, 2022
@baggepinnen baggepinnen deleted the sometests branch July 5, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants