Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rlocus #766

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Add rlocus #766

merged 2 commits into from
Nov 1, 2022

Conversation

mzaffalon
Copy link
Contributor

No description provided.

@mzaffalon
Copy link
Contributor Author

Addresses #764.

@baggepinnen
Copy link
Member

Cool, thanks for this PR!

We should probably add the output arguments to the docstring as well since there's more than one.

I've noticed that your editor/IDE appears to do some normalization of the code, removing white space etc. on lines unrelated to the PR. This is generally undesirable for pull requests since it adds a lot of noise in the git history, could you perhaps find a way to turn that off for repos that are not your own to avoid this?

@mzaffalon
Copy link
Contributor Author

Sorry about the poor thought-out doc string.

Yes, I have set up Emacs to remove trailing white spaces. I thought white spaces after the code line end was unwanted, but if it is your wish not to do that, I will disable that feature.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #766 (6dec61b) into master (7b4c1aa) will increase coverage by 94.57%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #766       +/-   ##
===========================================
+ Coverage    0.00%   94.57%   +94.57%     
===========================================
  Files           3        4        +1     
  Lines         291      295        +4     
===========================================
+ Hits            0      279      +279     
+ Misses        291       16      -275     
Impacted Files Coverage Δ
src/ControlSystems.jl 100.00% <ø> (ø)
src/root_locus.jl 97.10% <100.00%> (+97.10%) ⬆️
src/simulators.jl 87.50% <0.00%> (+87.50%) ⬆️
src/timeresp.jl 94.00% <0.00%> (+94.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@baggepinnen baggepinnen merged commit 76a687b into JuliaControl:master Nov 1, 2022
@mzaffalon
Copy link
Contributor Author

I see that there are tests for rlocusplot: do you think I should add any for rlocus, i.e. check against an analytical solution? From a quick check I saw a difference of 0.1-1.

@baggepinnen
Copy link
Member

Unfortunately, the tests for rlocusplot are quite bad, it's hard to test plots properly :/
A test for rlocus would thus be very welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants