Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for wrong u dimension in lsim #778

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

baggepinnen
Copy link
Member

If u was a vector, the changed method caused a confusing error message in a downstream method due to the creation of t of the wrong length

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #778 (b29ae07) into master (f545cc2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #778   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files           4        4           
  Lines         313      313           
=======================================
  Hits          304      304           
  Misses          9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.006 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.034 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@baggepinnen baggepinnen merged commit d4608ac into master Nov 28, 2022
@baggepinnen baggepinnen deleted the lsimerr branch November 28, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants