Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yscale --> _PlotScaleFunc in some plot recipes #799

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

baggepinnen
Copy link
Member

closes #798

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.006 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.034 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #799 (3018ea6) into master (77e2eaa) will decrease coverage by 97.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #799       +/-   ##
==========================================
- Coverage   97.14%   0.00%   -97.15%     
==========================================
  Files           4       3        -1     
  Lines         315     313        -2     
==========================================
- Hits          306       0      -306     
- Misses          9     313      +304     
Impacted Files Coverage Δ
src/root_locus.jl 0.00% <0.00%> (-97.78%) ⬇️
src/timeresp.jl 0.00% <0.00%> (-97.23%) ⬇️
src/simulators.jl 0.00% <0.00%> (-87.50%) ⬇️
src/ControlSystems.jl

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@baggepinnen baggepinnen merged commit 8840c9d into master Jan 31, 2023
@baggepinnen baggepinnen deleted the marginfix branch January 31, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

marginplot + setPlotScale("dB") = no magnitude plot
2 participants