Bugfix: Add used field to MD5 hash state #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ugh, looks like we don't have CI on this package 😄 could you add it in this PR also 😅 ? |
jw3126
reviewed
Oct 13, 2023
|
Thanks a lot! Could you bump the version? |
|
I just bumped the micro version, since changing compat is not a breaking change (anyone using an unsupported version will simply not be given this new version) |
MD5.jl currently uses undocumented and unexported internals of the SHA stdlib. PR #86 to SHA.jl added a new field, `used` to the SHA states. Since MD5 uses internal SHA functions which now look for this field, MD5 tests began to fail. This PR adds the needed `used` field, so MD5 now runs. The real fix is to not rely on SHA internals.
|
awesome thanks a lot @jakobnissen |
|
Would it be okay to set the new tagged version of this library with the bugfix as an official release (so that it can be simply installed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MD5.jl currently uses undocumented and unexported internals of the SHA stdlib. PR #86 to SHA.jl added a new field,
usedto the SHA states. Since MD5 uses internal SHA functions which now look for this field, MD5 tests began to fail.This PR adds the needed
usedfield, so MD5 now runs. The real fix is to not rely on SHA internals.Closes #11