Add compat entries for dependencies #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests will only pass after #300 has landed. |
ararslan
reviewed
Nov 9, 2019
| @@ -12,7 +12,11 @@ SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b" | |||
| Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" | |||
|
|
|||
| [compat] | |||
| Polynomials = ">= 0.1.0" | |||
| Polynomials = "0.6.0" | |||
| FFTW = "1.0" | |||
There was a problem hiding this comment.
This won't actually restrict AbstractFFTs, since FFTW permits any AbstractFFTs >= 0.3.
ararslan
reviewed
Nov 9, 2019
| @@ -12,7 +12,11 @@ SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b" | |||
| Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" | |||
|
|
|||
| [compat] | |||
| Polynomials = ">= 0.1.0" | |||
| Polynomials = "0.6.0" | |||
There was a problem hiding this comment.
Is there an issue with using other Polynomials versions in the 0.6.x series (if any exist)? If not, I think this should be
Suggested change
| Polynomials = "0.6.0" | |
| Polynomials = "0.6" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compat entries for all dependencies in line with the general guidelines of Julia auto-merge system for the General registry.
Do only merge after #300 has been merged. Afterwards tag a new release (patch version number increment). The auto-merge should work then.
Background / Why this is important:
See https://discourse.julialang.org/t/please-be-mindful-of-version-bounds-and-semantic-versioning-when-tagging-your-packages/30708/135.
Due to the changes in AbstractFFTs.jl (JuliaMath/AbstractFFTs.jl#26) we are in a broken state until #300 gets merged. See for example the complaints here.
This could and should have been avoided by
[compat]entries which would have set effective upper bounds on FFTW.jl. This way, we would have had the time to merge #300 whenever we want and then bump the FFTW version in[compat]. However, those compat entries didn't exist. This PR changes that for the after-#300 time.