Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat #56

Merged
merged 9 commits into from Jul 9, 2020
Merged

Update compat #56

merged 9 commits into from Jul 9, 2020

Conversation

JeffFessler
Copy link
Contributor

Thanks for accepting the previous PR. Unfortunately when I added the [compat] section I forgot to do a package update first, so I ended up pinning things to old versions of the packages, which then causes problems when trying to use this package with others. This PR simply updates the [compat] section to the latest versions of all the relevant packages.
Frankly I don't really understand why upper bounds in compat are required now, so I am not 100% sure that I have done this in the best way here. The good news at least it seems to pass the tests with the current versions of the included packages.

JeffFessler and others added 2 commits July 9, 2020 06:51
Merge pull request #54 from JeffFessler/master
@coveralls
Copy link

coveralls commented Jul 9, 2020

Coverage Status

Coverage remained the same at 90.283% when pulling a8995f5 on JeffFessler:master into 7f2da5b on JuliaDSP:master.

@JeffFessler
Copy link
Contributor Author

So this update passes Julia 1.4 but fails tests for earlier versions of Julia.
I guess one or more of the other packages must require Julia 1.4.
My view is that there is little point in supporting old versions of Julia with this update of Wavelets.jl (people using older versions of Julia can use earlier releases of this package) so I have removed the tests of older versions from the CI file. Maybe there is some way to support both but I don't know how...

@johnnychen94
Copy link
Contributor

johnnychen94 commented Jul 9, 2020

The test fails because you have Manifest.toml checked in, those *_jll packages are artifacts and is not compatible to Julia < 1.3

Once Manifest.toml is removed, it should be good.

Copy link
Contributor

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some random comment on the Project.toml without any knowledge about the status of Wavelets.jl

Would be good to also add Manifest.toml to .gitignore file

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
JeffFessler and others added 4 commits July 9, 2020 10:11
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
Copy link
Contributor

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for the content of Project.toml, whether these versions are valid in Wavelet.jl is out of my knowledge.

@JeffFessler
Copy link
Contributor Author

Thanks to @johnnychen94's help, the tests now pass so this is ready for @gummif to review.

@gummif
Copy link
Member

gummif commented Jul 9, 2020

Thanks

@gummif gummif merged commit afeb1a2 into JuliaDSP:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants