New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compat #56
Update compat #56
Conversation
Merge pull request #54 from JeffFessler/master
So this update passes Julia 1.4 but fails tests for earlier versions of Julia. |
The test fails because you have Once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some random comment on the Project.toml
without any knowledge about the status of Wavelets.jl
Would be good to also add Manifest.toml
to .gitignore
file
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval for the content of Project.toml
, whether these versions are valid in Wavelet.jl is out of my knowledge.
Thanks to @johnnychen94's help, the tests now pass so this is ready for @gummif to review. |
Thanks |
Thanks for accepting the previous PR. Unfortunately when I added the
[compat]
section I forgot to do a packageupdate
first, so I ended up pinning things to old versions of the packages, which then causes problems when trying to use this package with others. This PR simply updates the[compat]
section to the latest versions of all the relevant packages.Frankly I don't really understand why upper bounds in compat are required now, so I am not 100% sure that I have done this in the best way here. The good news at least it seems to pass the tests with the current versions of the included packages.